Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs) Adding a hardware issues page under troubleshooting #2360

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Nick-Munnich
Copy link
Contributor

@Nick-Munnich Nick-Munnich commented Jul 3, 2024

This PR adds a "hardware issues" page under troubleshooting. It discusses:

  • Identifying problems with pins
  • Firmware changes needed after soldering a bodge wire
  • Common physical problems with antennas
  • Advice for troubleshooting the physical problems

In the process, there are also two new shields to help with troubleshooting: tester_pro_micro and tester_xiao. This partially resolves #2410, though I would really like a more general solution eventually.

@caksoylar caksoylar added enhancement New feature or request documentation Improvements or additions to documentation labels Jul 3, 2024
@Nick-Munnich Nick-Munnich changed the title Initial creation of hardware issues page. feat(docs) Adding a hardware issues page under troubleshooting Aug 15, 2024
@Nick-Munnich Nick-Munnich marked this pull request as ready for review August 15, 2024 14:07
@Nick-Munnich Nick-Munnich requested a review from a team as a code owner August 15, 2024 14:07
@Nick-Munnich
Copy link
Contributor Author

Did a big overhaul of this, updated the title and description accordingly.

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mostly high level thoughts; FWIW I think this is a pretty large undertaking.

app/boards/shields/tester_pro_micro/Kconfig.defconfig Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
@caksoylar
Copy link
Contributor

Oh, I think this needs to be rebased to fix the broken link in build.

docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
Comment on lines 42 to 44
This page contains _general advice_ for troubleshooting hardware issues. ZMK **does not** provide any sort of hardware support. If the below points are unable to resolve your problem, contact your vendor/manufacturer for assistance.

You can contact ZMK for assistance with resolving firmware issues _after_ resolving your hardware issues, if your vendor/manufacturer is unable to provide said support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This page contains _general advice_ for troubleshooting hardware issues. ZMK **does not** provide any sort of hardware support. If the below points are unable to resolve your problem, contact your vendor/manufacturer for assistance.
You can contact ZMK for assistance with resolving firmware issues _after_ resolving your hardware issues, if your vendor/manufacturer is unable to provide said support.
This page contains _general advice_ for troubleshooting hardware issues. Your first point of call should always be the vendor/manufacturer of the product. If you bought it, your purchase may include access to dedicated support channels and a warranty.
ZMK is software—not hardware—and while its community is often happy to help, ZMK collaborators cannot provide official support for hardware they did not create.

Probably too region-specific to link to this or this, but if you've got any better ideas to remind end-users that they may have some sort of recourse before trying to fix it themselves—especially if something doesn't work OOTB—that'd probably be a good thing to try and get across here.

Maybe :::danger would be appropriate here; see later comments regarding the removal of a different infobox.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrasing this is a good idea, and reminding about warranty/support is also good. I'm not sold on remarking that the community is happy to help - part of my motivation for writing this page was out of frustration with the aliexpress vendors essentially using the ZMK discord as free tech support, though others may see it differently...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a slight wording change like "the community might be able to provide help"? Less committal but also reflecting the reality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on remarking that the community is happy to help

I did qualify that happy with an "often", not "always", but very fair; feel free to rethink. I was mostly concerned about how the original wording was interpretable as obliging ZMK collaborators to help with firmware...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried rewriting - let me know what you think.

docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
docs/docs/troubleshooting/hardware-issues.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Hardware troubleshooting shield
4 participants