Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix fragment links in testing stores page #2351

Merged
merged 2 commits into from
Aug 15, 2023
Merged

docs: fix fragment links in testing stores page #2351

merged 2 commits into from
Aug 15, 2023

Conversation

Theiaz
Copy link
Contributor

@Theiaz Theiaz commented Aug 15, 2023

Tested with deploy preview
Issue

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit c6e771e
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/64db45a989762800080e72d9
😎 Deploy Preview https://deploy-preview-2351--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NozomuIkuta
Copy link

NozomuIkuta commented Aug 15, 2023

JFYI: you can link a PR to an issue by using GitHub keywords, so that the issue will be closed automatically when the PR is merged, and authors don't have to manage their association manually.

@posva posva changed the title Fix fragment links in testing stores page docs: fix fragment links in testing stores page Aug 15, 2023
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I removed them since they appear on the right now

@posva posva linked an issue Aug 15, 2023 that may be closed by this pull request
@posva posva merged commit 95b5f37 into vuejs:v2 Aug 15, 2023
5 checks passed
@Theiaz
Copy link
Contributor Author

Theiaz commented Aug 15, 2023

JFYI: you can link a PR to an issue by using GitHub keywords, so that the issue will be closed automatically when the PR is merged, and authors don't have to manage their association manually.

Thanks for the tip. I know I can do it, but i was in hurry and I'm more familiar with gitlab.

niceplugin added a commit to niceplugin/Vuejs-Pinia-KO that referenced this pull request Aug 27, 2023
niceplugin added a commit to niceplugin/Vuejs-Pinia-KO that referenced this pull request Aug 27, 2023
* docs: fix fragment links in testing stores page (vuejs#2351)

* docs: add portuguese documentation link (vuejs#2345)

* docs: broken play button on Vue School links (vuejs#2360)

* docs: Add Link to Vue.js Certification (vuejs#2362)

* docs: improved syntax (vuejs#2369)

* docs: mastering pinia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table of content links are broken on "Testing stores" page
3 participants