-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Search attributes db #5376
Draft
ketsiambaku
wants to merge
18
commits into
uber:master
Choose a base branch
from
ketsiambaku:search-attributes-db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0ea253 - Browse repository at this point
Copy the full SHA e0ea253View commit details -
Configuration menu - View commit details
-
Copy full SHA for a72878d - Browse repository at this point
Copy the full SHA a72878dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9c067c - Browse repository at this point
Copy the full SHA e9c067cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c30b016 - Browse repository at this point
Copy the full SHA c30b016View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf0ff0b - Browse repository at this point
Copy the full SHA cf0ff0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d6ad21 - Browse repository at this point
Copy the full SHA 7d6ad21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc9f5f - Browse repository at this point
Copy the full SHA 5fc9f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for eab6e0c - Browse repository at this point
Copy the full SHA eab6e0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 003bd60 - Browse repository at this point
Copy the full SHA 003bd60View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae227f5 - Browse repository at this point
Copy the full SHA ae227f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82efde4 - Browse repository at this point
Copy the full SHA 82efde4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f3b5c5 - Browse repository at this point
Copy the full SHA 1f3b5c5View commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 90fd1b9 - Browse repository at this point
Copy the full SHA 90fd1b9View commit details
Commits on Aug 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b940808 - Browse repository at this point
Copy the full SHA b940808View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb8fd0 - Browse repository at this point
Copy the full SHA fdb8fd0View commit details -
Validate search-attribute-key so keys are fine in advanced search (ub…
…er#5340) * Validate search-attribute-key so keys are fine in advanced search ElasticSearch engine fails to parse keys with dashes, making those search-attributes broken for CLI and web. Validate search-attribute before creating on server so it looks like a valid variable name in most of languages, should be more than expected for programmers. The reason it is not in the server, is that currently even at Uber we have keys with dashes, and it will be a problem if we gonna migrate domains between clusters. * Return err to surface the expected search-attr format Otherwise it is not clear what the `--key` should be.
Configuration menu - View commit details
-
Copy full SHA for e5f36a0 - Browse repository at this point
Copy the full SHA e5f36a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad72190 - Browse repository at this point
Copy the full SHA ad72190View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a9af08 - Browse repository at this point
Copy the full SHA 8a9af08View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.