Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Search attributes db #5376

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ketsiambaku
Copy link
Contributor

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

ketsiambaku and others added 18 commits August 13, 2023 09:46
…er#5340)

* Validate search-attribute-key so keys are fine in advanced search

ElasticSearch engine fails to parse keys with dashes, making those
search-attributes broken for CLI and web.
Validate search-attribute before creating on server so it looks like a
valid variable name in most of languages, should be more than expected for
programmers.

The reason it is not in the server, is that currently even at Uber we
have keys with dashes, and it will be a problem if we gonna migrate
domains between clusters.

* Return err to surface the expected search-attr format

Otherwise it is not clear what the `--key` should be.
@ketsiambaku ketsiambaku marked this pull request as draft August 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants