-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3DS2 Analytics Delegate #9430
Open
Twigz
wants to merge
6
commits into
feature/3ds2-2.2
Choose a base branch
from
feature/3ds2-analytics
base: feature/3ds2-2.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3DS2 Analytics Delegate #9430
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c84da84
Allows for auto-submittal of the challenge if the view is OOB
Twigz c017c7a
Analytics implementation
Twigz 7c80ec8
Merge branch 'feature/3ds2-2.2' into feature/3ds2-analytics
Twigz b439868
linting
Twigz a269f76
Update 3ds2sdk.api
Twigz e16fde7
Fix issues
Twigz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
3ds2sdk/src/main/kotlin/com/stripe/android/stripe3ds2/utils/AnalyticsDelegate.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.stripe.android.stripe3ds2.utils | ||
|
||
interface AnalyticsDelegate { | ||
fun didReceiveChallengeResponseWithTransactionId(transactionId: String, flow: String) | ||
|
||
fun cancelButtonTappedWithTransactionId(transactionId: String) | ||
|
||
fun otpSubmitButtonTappedWithTransactionID(transactionId: String) | ||
|
||
fun oobContinueButtonTappedWithTransactionID(transactionId: String) | ||
|
||
fun oobFlowDidPause(transactionId: String) | ||
|
||
fun oobFlowDidResume(transactionId: String) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work because it will not survive process death. I discussed with the team and we decided a java service provider will be the best approach. Can you remove this and replace with a
ServiceLoader
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry, thought I posted a comment about the Singleton to ask how your team wanted to handle that. 👍🏼