3DS2 Analytics Delegate #9430
Open
3DS2 Analytics Delegate #9430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjclawson-stripe
requested changes
Oct 11, 2024
| @@ -200,3 +217,18 @@ class StripeThreeDs2ServiceImpl @VisibleForTesting internal constructor( | |||
| private const val STRIPE_SDK_REFERENCE_NUMBER = "3DS_LOA_SDK_STIN_020100_00142" | |||
| } | |||
| } | |||
|
|
|||
| class AnalyticsSingleton private constructor() { | |||
There was a problem hiding this comment.
This won't work because it will not survive process death. I discussed with the team and we decided a java service provider will be the best approach. Can you remove this and replace with a ServiceLoader?
There was a problem hiding this comment.
Yes sorry, thought I posted a comment about the Singleton to ask how your team wanted to handle that. 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 3DS2 Analytics Delegate
Motivation
This allow the payments SDK to have finer grain control over information provided by the 3DS2 SDK, so that additional analytics information can be provided.
Testing