Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F-G lettered article stubs from glossary #3827

Merged
merged 18 commits into from
Sep 2, 2020
Merged

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Jul 5, 2020

Part of organization effort - #3143

Adds articles:

  • Fail
  • Featured Artist (duplicate content)
  • Full Combo
  • Geki
  • Grade
  • Graveyard
  • Grid Snapping

Modifies articles:

  • Guest Difficulty

@Pennek Pennek mentioned this pull request Jul 5, 2020
24 tasks
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most suggestions relate to formatting. Otherwise, pretty solid 👍

Consider adding this Consider adding an HTML comment that lists which words need to be linked eventually:

Fail

  • break

Full combo

  • missing (line 8 diff)
  • sliderbreaking (line 8 diff)
  • combo multiplier effect (line 10 diff)

Grade

  • Hidden (mod) (line 10 diff)
  • Flashlight (mod) (line 10 diff)
  • Fade-in (mod) (line 10 diff)

wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Fail/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Fail/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Graveyard/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Graveyard/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Grid_Snapping/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Grid_Snapping/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Grid_Snapping/en.md Outdated Show resolved Hide resolved
@cl8n cl8n added this to the July 2020 milestone Jul 10, 2020
cl8n
cl8n previously requested changes Jul 10, 2020
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked through FC article so far

wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
wiki/Beatmaps/Beatmapsets/Guest_difficulty/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi self-assigned this Jul 11, 2020
@MegaApplePi MegaApplePi added the state/blocked don't merge label Jul 11, 2020
@MegaApplePi MegaApplePi removed their assignment Aug 2, 2020
@MegaApplePi MegaApplePi removed the state/blocked don't merge label Aug 2, 2020
wiki/Geki/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi self-assigned this Sep 2, 2020
@MegaApplePi MegaApplePi dismissed cl8n’s stale review September 2, 2020 01:08

The list was removed.

@MegaApplePi MegaApplePi merged commit bca2758 into ppy:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants