Downloads: if item is a portal item and it is multilayer, export all layers #427
Conversation
| "@esri/arcgis-rest-feature-layer": "^2.14.1", | ||
| "@esri/arcgis-rest-portal": "^2.14.1", | ||
| "@esri/arcgis-rest-request": "^2.14.1", |
There was a problem hiding this comment.
I'm glad to see these become peerDepenencies, but Unfortunately, this will manifest as breaking change b/c people will now need to install these.
Also, I'm considering consolidating this package w/ hub-content (#306), which would solve this issue.
I think we should update the versions, but leave them as dependencies for now.
| @@ -42,7 +42,12 @@ export function portalRequestDatasetExport( | |||
|
|
|||
| function composeExportParameters(params: any) { | |||
| const { datasetId, spatialRefId, where } = params; | |||
| const layerId = datasetId.split("_")[1] || 0; | |||
| const layerId = datasetId.split("_")[1]; | |||
There was a problem hiding this comment.
FYI - there's a util for this:
https://esri.github.io/hub.js/api/content/parseDatasetId/
Unfortunately it's not available to this package, let's leave a TODO comment like this
| const layerId = datasetId.split("_")[1]; | |
| // TODO: move parseDatasetId() to hub-common and use that here | |
| const layerId = datasetId.split("_")[1]; |
| "devDependencies": { | ||
| "@esri/arcgis-rest-auth": "^2.14.1", | ||
| "@esri/arcgis-rest-auth": "^2.21.0", |
There was a problem hiding this comment.
Also, we'll need to update these devDependencies in all other packages to match these (even if they're dependencies in this package), as per https://github.com/Esri/hub.js/wiki/Dependencies#outside-the-monorepo:
Then you would bump the version of the dependency in all existing devDependencies within the monorepo to the new minor version.
rgwozdz
force-pushed
the
p/downloads-export
branch
from
d3d714f
to
97b32f4
Compare
…yer, export all layers affects: @esri/hub-oauth-demo, @esri/hub-annotations, @esri/hub-common, @esri/hub-content, @esri/hub-downloads, @esri/hub-events, @esri/hub-initiatives, @esri/hub-search, @esri/hub-sites, @esri/hub-surveys, @esri/hub-teams
affects: @esri/hub-downloads
rgwozdz
force-pushed
the
p/downloads-export
branch
from
f5db571
to
0641f94
Compare
Download export requests for multilayer, portal items should export ALL layers. This PR ensures that occurs by remove the "layers" property from the
exportItemcall.