Specify "Collection" when searching for multilayer KML or CSV exports #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgwozdz
force-pushed
the
p/downloads-collection-search
branch
from
9a19542
to
fd0ac9a
Compare
packages/downloads/src/portal/portal-request-download-metadata.ts
Outdated
Show resolved
Hide resolved
packages/downloads/src/portal/portal-request-download-metadata.ts
Outdated
Show resolved
Hide resolved
tomwayson
reviewed
Nov 16, 2020
rgwozdz
force-pushed
the
p/downloads-collection-search
branch
from
6c8d0a1
to
e15bdc8
Compare
…d metadata request affects: @esri/hub-oauth-demo, @esri/hub-downloads
affects: @esri/hub-downloads
affects: @esri/hub-downloads
affects: @esri/hub-downloads
mikeringrose
approved these changes
Nov 18, 2020
Comment on lines
+11
to
+14
| enum ItemTypes { | ||
| FeatureService = "Feature Service", | ||
| MapService = "Map Service" | ||
| } |
There was a problem hiding this comment.
These could probably just be constants. An enum here might be overkill.
rgwozdz
force-pushed
the
p/downloads-collection-search
branch
from
d5da2dc
to
a3a57df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an item has multiple layers, and a KML or CSV item is requested, the /export endpoint actually tags the new export item as
CSV CollectionandKML Collection. As a result, we need to search for that type (rather than KML or CSV) when checking if such an export is already cached.Further, for multi-layer exports, we need fetch the last-edit-date of each layer and see if any are more recent then the timestamp of the cached multilayer export.
I moved the rest-js dependencies in hub-downloads to peers, but had to update the versions to leverage recent rest-js changes.
Also, there are some changes due to auto-linting that didn't occur earlier.