-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAZ shield: added three physical layouts #2567
base: main
Are you sure you want to change the base?
Conversation
Could you move them into a separate file called |
should be done, I think the syntax is correct, but I haven't done that in my own config so not sure it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the nit, but if you haven't, it would be good to try the final revision on Studio.
@@ -0,0 +1,187 @@ | |||
/* | |||
* Copyright (c) 2020 The ZMK Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd either fix the date or remove the header, we don't seem to be sticking strictly to adding these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. firmware built, but I have no method to flash at the moment so testing in studio will wait until tomorrow.
added 3 physical layouts and position maps to the qaz shield. includes big bar, split bar (which remains the default), and split big bar (big bar mounted on two switches in the stab stems POS-style). using physical layouts simplifies adding ZMK Studio support for end-users.