Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAZ shield: added three physical layouts #2567

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zackforbing
Copy link

@zackforbing zackforbing commented Oct 18, 2024

added 3 physical layouts and position maps to the qaz shield. includes big bar, split bar (which remains the default), and split big bar (big bar mounted on two switches in the stab stems POS-style). using physical layouts simplifies adding ZMK Studio support for end-users.

@zackforbing zackforbing changed the title added three physical layouts QAZ shield: added three physical layouts Oct 18, 2024
@Nick-Munnich
Copy link
Contributor

Could you move them into a separate file called qaz-layouts.dtsi please?

@Nick-Munnich Nick-Munnich added the shields PRs and issues related to shields label Oct 18, 2024
@zackforbing
Copy link
Author

Could you move them into a separate file called qaz-layouts.dtsi please?

should be done, I think the syntax is correct, but I haven't done that in my own config so not sure it works.

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the nit, but if you haven't, it would be good to try the final revision on Studio.

@@ -0,0 +1,187 @@
/*
* Copyright (c) 2020 The ZMK Contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd either fix the date or remove the header, we don't seem to be sticking strictly to adding these.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. firmware built, but I have no method to flash at the moment so testing in studio will wait until tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants