-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement activity-toolbar story #768
base: main
Are you sure you want to change the base?
Implement activity-toolbar story #768
Conversation
Deploying react-science with Cloudflare Pages
|
I like the functionality and that the panels fully disappear when no panel is open. Not sure if it is now it should be implemented and @stropitek should decide. Here are my thoughts and probably we should create new issues:
|
I agree with that.
The goal of this PR is to:
Saving the opened / closed panels is related to the state and will be handled in the final application, not in react-science.
Yes
Not in scope, maybe in the future (let's focus on more fundamental questions first).
With @targos we think that the demo app should be removed ultimately and we should only keep stories. We see react-science as a collection of small components to build complex applications, not large and complex components to "easily" build an app.
I do agree with that. I think if we can move away from accordions and instead have 1 to 2 activities speparated by a split slider that would be great. We don't need 2 ways to hide the same content, 1 is enough. @wadjih-bencheikh18 I got inspired by Webstorm, which does things slightly differently to VS code: @wadjih-bencheikh18 I will discuss this with @lpatiny and @targos and come back to you with more specific instructions. |
Here is what we decided:
Please wait for #776 to be merged and use the |
closes : #767
Test here: https://f9802468.react-science.pages.dev/stories/?path=/story/components-toolbar--activity-toolbar