Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Header order -> section order #334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

casaper
Copy link
Contributor

@casaper casaper commented Feb 4, 2022

Fixed:

  1. _.uniqWith not within the ## Collection* header section
  2. _.uniqWith's ### Browser Support for -> #### Browser Support for so it is arranged within not adjacent of _.uniqWith
  3. ### _.random header indentation
  4. ## Reference at the end, because it seems more appropriate there

This allows to have the grouping with GitHubs header navigator:

image

and with the GitHub pages version of this readme, would then also list uniqWith in the collections section:

http://you-dont-need.github.io/You-Dont-Need-Lodash-Underscore/#/?id=_uniq

It wasn in the wrong place, not after _.uniq, as expected.

Additionally it's "Browser Support" header was h3 instead h4,
so that didn't help with semantics and navigation as well.
Since it is not a function description, I guess it is
more logic to have this one at the end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant