[screensaver.turnoff] v0.10.2 #1213
Conversation
Travis BuddyHey Dag Wieers, |
screensaver.turnoff/addon.xml
Outdated
|
|
||
| Next to managing your display, it can also manage your device power state, log your profile off or mute audio to avoid sounds through your A/V receiver. | ||
| </description> | ||
| <license>GNU General Public License, v2+</license> |
There was a problem hiding this comment.
I fixed it now.
It doesn't seem to be a requirement though, as it is missing from the docs and just recently other add-ons were merged that did not use SPDX for their license-tag.
xbmc/addon-check#126
There was a problem hiding this comment.
I documented on the wiki some months ago: https://kodi.wiki/view/Addon.xml#.3Clicense.3E
It's not mandatory but it is nice to start having some sort of standardization. Might be added to the addon checker if someone steps up.
Thanks for adjusting
There was a problem hiding this comment.
Oh, I agree with having SPDX as a standard.
| def run(): | ||
| ''' Runs the screensaver ''' | ||
|
|
||
| # If player has media, avoid running |
There was a problem hiding this comment.
I assume this is because of audio playing?
There was a problem hiding this comment.
Or when testing the screensaver when media is playing.
This was giving me issues, when I discovered this is not supposed to work in Kodi.
(The screensaver test button should be disabled when media is playing IMO)
- Create separate entrypoint - Improve stability - Add more unit tests - Add sanity tests, unit tests and coverage support - Use JSON-RPC for all built-ins - Improvements for Python 3 - Support Odroid-C2 display method - Support RPi touchscreen display method - Improve mute and unmuting audio using JSON-RPC - Fix translations - Fix an issue when stopping the screensaver
dagwieers
force-pushed
the
screensaver.turnoff-0.10.2
branch
from
10b4cfc
to
a99b5f1
Compare
Travis BuddyHey Dag Wieers, |
Description
Checklist: