Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Preliminary RootTree APIs #390

Merged
merged 11 commits into from
Apr 14, 2024
Merged

feat: Preliminary RootTree APIs #390

merged 11 commits into from
Apr 14, 2024

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jan 2, 2024

With these two PRs:

it's now possible to have a single root API for both the public and private file system!

This implements it.


  • Expose the RootTree API
  • Fix compilation of wnfs-nameaccumulator when the num-bigint-dig feature is disabled
  • Don't use .unwrap() in AccessKey APIs and make serializing/deserializing fallible
  • Remove some println!s that got left over from debugging

Also:
- Fix nameaccumulator lib not working when the "rug" features is on, but "num-bigint-dig" is off.
- Avoid `.unwrap()` in `AccessKey`.
@matheus23 matheus23 self-assigned this Jan 2, 2024
@matheus23 matheus23 requested a review from a team as a code owner January 2, 2024 11:15
@matheus23 matheus23 changed the title feat: Preliminary RootTree APIs. feat: Preliminary RootTree APIs Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: Patch coverage is 59.61538% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 54.35%. Comparing base (87839b7) to head (be9def5).

❗ Current head be9def5 differs from pull request most recent head 2b12119. Consider uploading reports for the commit 2b12119 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   54.57%   54.35%   -0.22%     
==========================================
  Files          57       57              
  Lines        3956     4003      +47     
  Branches      963      980      +17     
==========================================
+ Hits         2159     2176      +17     
- Misses       1175     1191      +16     
- Partials      622      636      +14     
Files Coverage Δ
wnfs-nameaccumulator/src/traits.rs 66.66% <ø> (-11.67%) ⬇️
wnfs/src/lib.rs 90.00% <ø> (ø)
wnfs/src/private/node/keys.rs 78.94% <ø> (ø)
wnfs/src/private/previous.rs 71.18% <ø> (ø)
wnfs/src/public/directory.rs 67.60% <ø> (ø)
wnfs/src/private/keys/access.rs 57.57% <0.00%> (+3.29%) ⬆️
wnfs/src/public/file.rs 66.39% <20.00%> (-2.58%) ⬇️
wnfs/src/root_tree.rs 63.15% <62.88%> (-0.23%) ⬇️

... and 3 files with indirect coverage changes

@matheus23 matheus23 merged commit 1554bb3 into main Apr 14, 2024
10 checks passed
@matheus23 matheus23 deleted the matheus23/root-tree branch April 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant