Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-compose): add --profile suggestion #2027

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

tomoakiichige
Copy link
Contributor

@tomoakiichige tomoakiichige commented Jul 20, 2023

When using the --profile option in the docker-compose command, suggestions for the list of profiles are now provided.

In addition, some operations are common to the existing servicesGenerator, so they have been extracted into a function.

@withfig-bot
Copy link
Collaborator

withfig-bot commented Jul 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

Overview

src/docker-compose.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @tomoakiichige,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@tomoakiichige
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Jul 20, 2023
@tomoakiichige tomoakiichige changed the title feat: add profile autocompletion to docker-compose feat(docker-compose): add --profile suggestion Jul 20, 2023
@mschrage mschrage merged commit 8521546 into withfig:master Jul 25, 2023
4 checks passed
@withfig withfig locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants