Skip to content

Commit

Permalink
fix: remove unnecessary react-refreshfrom dev-server's dependencies (#…
Browse files Browse the repository at this point in the history
…5404)

fix: remove unnecessary react-refresh-plugin from dev-server's dependencies
  • Loading branch information
LingyuCoder authored Jan 23, 2024
1 parent cb28ac5 commit 114c5de
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/rspack-dev-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
"devDependencies": {
"@rspack/core": "workspace:*",
"@rspack/dev-server": "workspace:*",
"@rspack/plugin-react-refresh": "workspace:*",
"@types/connect-history-api-fallback": "1.3.5",
"@types/express": "4.17.14",
"@types/mime-types": "2.1.1",
"@types/ws": "8.5.3",
"fs-extra": "11.1.0"
},
"dependencies": {
"@rspack/plugin-react-refresh": "workspace:*",
"chokidar": "3.5.3",
"connect-history-api-fallback": "2.0.0",
"express": "4.18.1",
Expand All @@ -52,4 +52,4 @@
"peerDependencies": {
"@rspack/core": "*"
}
}
}
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 114c5de

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

name base current %
10000_development-mode + exec 1.71 s ± 35 ms 1.74 s ± 37 ms +1.86%
10000_development-mode_hmr + exec 1 s ± 11 ms 1.02 s ± 12 ms +1.82%
10000_production-mode + exec 2.74 s ± 57 ms 2.76 s ± 51 ms +0.57%
threejs_development-mode_10x + exec 2.02 s ± 18 ms 2.01 s ± 14 ms -0.69%
threejs_development-mode_10x_hmr + exec 1.33 s ± 5.1 ms 1.33 s ± 9.7 ms -0.26%
threejs_production-mode_10x + exec 5.94 s ± 39 ms 5.92 s ± 33 ms -0.22%

Please sign in to comment.