fix(slots): properly warn if slot invoked in setup

[yangxiuxiu1115]

fix #12194

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB	38 kB	34.2 kB
vue.global.prod.js	159 kB	57.9 kB	51.4 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.9 kB	18.3 kB	16.7 kB
createApp	55 kB	21.3 kB	19.4 kB
createSSRApp	59 kB	23 kB	20.9 kB
defineCustomElement	59.8 kB	22.8 kB	20.8 kB
overall	68.7 kB	26.3 kB	24 kB

[pkg-pr-new]

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12195

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12195

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12195

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12195

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12195

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12195

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12195

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12195

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12195

vue

pnpm add https://pkg.pr.new/vue@12195

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12195

commit: af6d2f6

[edison1105]

The condition will cause the following warning to never trigger. Removing the condition || (ctx && ctx.root === currentInstance.root) will also prevent the warning from triggering in

core/packages/runtime-core/__tests__/componentSlots.spec.ts

Line 324 in 41e10dc

'Slot "default" invoked outside of the render function',

. I think a test case needs to be added to verify the warning will trigger.

[yangxiuxiu1115]

I don't see anything wrong with it .
added a basic warn case

[edison1105]

core/packages/runtime-core/src/vnode.ts

Line 853 in cb34b28

children = { default: children, _ctx: currentRenderingInstance }

if the slot value is a function the rawSlots always has the _ctx key.

so all test cases pass using the following conditions

if (
  __DEV__ &&
  currentInstance &&
  (ctx && ctx.root === currentInstance.root)

[yangxiuxiu1115]

I've added a few test cases, are they correct?

[edison1105]

All test cases are correct.
the proper condition should be:

if (
  __DEV__ &&
  currentInstance &&
  !(ctx === null && currentRenderingInstance) &&
  !(ctx && ctx.root !== currentInstance.root)
)

[yangxiuxiu1115]

cool!!!