fix(runner): resolve and normalize absolute path in fetchModule

[hi-ogawa]

Description

• closes virtual file system is broken in v6 #18223

Not so confident that this is a proper fix nor the issue needs fix, but I'm thinking about what would require to support #18223 and hopefully it helps deciding the fate of the issue (bug or wontfix).

One thing I noticed that it looks possible to dedupe/normalize /abs-path-to/src/etc -> /src/etc on server side (fetchModule) and module identity is still kept intact on runner side. For FetchModuleResult.cache detection, I replaced getModuleByUrl with ensureEntryFromUrl and I'm wondering what's the downside of this.

todo

• decide on file:// support
  • check if build works?

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[hi-ogawa]

normalizeAbsoluteUrl also noramlizes file:///... to support this test case, but I'm not sure if we needs to keep this if we go with externalizing file:// entirely #17369. Also v5's ssrLoadModule('file://') doesn't seem to work either.

vite/packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts

Lines 17 to 20 in 5e8e7ec

	// loads the same module if id is a file url
	const fileUrl = new _URL('./fixtures/simple.js', import.meta.url)
	const mod2 = await runner.import(fileUrl.toString())
	expect(mod).toBe(mod2)

[hi-ogawa]

After the change, for Windows, import("C:/...") doesn't work but probably this behavior hasn't changed from v5? (Also node doesn't support it either as they require import("file://...") for windows path)

I think I added this test case in #17422 saying it's broken in v6, but maybe it was already broken on v5 if I tested it on Windows 😅

[sheremet-va]

I guess the addition of resolveId in fetchModule makes this irrelevant. The only downside is the additional call to the server if the entry point is not normalized, but it was already imported.

If we move this to the environment, then maybe this whole function can be removed, which also makes it so the root is not required anymore

[hi-ogawa]

Okay, I moved everything to fetchModule including file:// handling. It looks like this works, but the behavior of file:// might be actually different from browser and v5 since Astro is relying on userland plugin #17369 (comment)

(though In my opinion, supporting file:// out of the box seems nice to have anyways)

[hi-ogawa]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on f001b7d: Open

suite	result	latest scheduled
astro	❌ failure	❌ failure
remix	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
unocss	❌ failure	❌ failure
vike	❌ failure	❌ failure
vitest	❌ failure	❌ failure

✅ analogjs, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress