chore(sinks, codecs): Remove legacy EncodingConfiguration

[pablosichert]

Related to #9459.

Closes #12162.
Closes #12127.
Closes #12134.

Tip: Use the "hide whitespace" option in the files tab when reviewing.

[netlify]

✅ Deploy Preview for vector-project ready!

Name	Link
🔨 Latest commit	d2cb825
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/62cf33530cfefe000921070d
😎 Deploy Preview	https://deploy-preview-13518--vector-project.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[jszwedko]

These are some good diff stats 😄

I'll go over this in more detail soon, but one thing that I think we need to add here is a note to the 0.24.0 upgrade guide explaining how to migrate.

[jszwedko]

🎉

[pablosichert]

one thing that I think we need to add here is a note to the 0.24.0 upgrade guide explaining how to migrate.

The deprecation and migration path has already been covered in the 0.23.0 guide. This PR will bring those changes into effect by removing the compatibility layer.

I think we can add a short note in the 0.24.0 guide that refers to the 0.23.0 guide?

[jszwedko]

one thing that I think we need to add here is a note to the 0.24.0 upgrade guide explaining how to migrate.

The deprecation and migration path has already been covered in the 0.23.0 guide. This PR will bring those changes into effect by removing the compatibility layer.

I think we can a short note in the 0.24.0 guide that refers to the 0.23.0 guide?

Ah, true, that would work. We can announce the breaking change and link to the deprecation warning from 0.23.0 and mention it includes the migration details.

[github-actions]

Soak Test Results

Baseline: 176060c
Comparison: 7128751
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison outlier %	comparison CoV	erratic	declared erratic
datadog_agent_remap_blackhole_acks	2.93MiB	4.82	100.00%	60.86MiB	4.7MiB	97.93KiB	0	0.0772528	63.8MiB	3.61MiB	75.57KiB	0	0.05659	False	False
http_text_to_http_json	1.31MiB	3.42	100.00%	38.12MiB	1.42MiB	29.61KiB	0	0.0371553	39.43MiB	1.59MiB	33.32KiB	0	0.0404236	False	False
syslog_loki	472.56KiB	3.21	100.00%	14.38MiB	710.24KiB	14.55KiB	0	0.048223	14.84MiB	1017.54KiB	20.68KiB	0	0.0669397	False	False
datadog_agent_remap_blackhole	2.0MiB	3.15	100.00%	63.54MiB	4.32MiB	90.07KiB	0	0.0680333	65.54MiB	3.0MiB	62.65KiB	0	0.0457975	False	False
splunk_hec_route_s3	612.64KiB	3.14	100.00%	19.03MiB	2.26MiB	47.17KiB	0	0.119	19.63MiB	2.15MiB	44.92KiB	0	0.109358	False	False
socket_to_socket_blackhole	307.93KiB	2.26	100.00%	13.32MiB	311.06KiB	6.35KiB	0	0.0228074	13.62MiB	266.6KiB	5.44KiB	0	0.0191159	False	False
datadog_agent_remap_datadog_logs	932.51KiB	1.44	100.00%	63.06MiB	1.61MiB	33.65KiB	0	0.0254526	63.97MiB	4.64MiB	96.68KiB	0	0.0725719	False	False
syslog_humio_logs	64.19KiB	0.36	100.00%	17.44MiB	519.96KiB	10.61KiB	0	0.0291081	17.5MiB	497.65KiB	10.19KiB	0	0.0277589	False	False
datadog_agent_remap_datadog_logs_acks	223.53KiB	0.35	95.08%	62.72MiB	2.44MiB	51.06KiB	0	0.038861	62.94MiB	4.88MiB	101.51KiB	0	0.0774683	False	False
http_pipelines_blackhole	2.65KiB	0.16	60.94%	1.62MiB	80.93KiB	1.65KiB	0	0.0486988	1.63MiB	127.99KiB	2.61KiB	0	0.0768913	False	False
http_pipelines_blackhole_acks	1.42KiB	0.12	36.12%	1.16MiB	118.62KiB	2.41KiB	0	0.0996118	1.16MiB	90.08KiB	1.84KiB	0	0.075554	False	False
syslog_log2metric_splunk_hec_metrics	14.5KiB	0.08	42.65%	18.84MiB	822.86KiB	16.78KiB	0	0.042642	18.85MiB	960.14KiB	19.54KiB	0	0.049719	False	False
splunk_hec_to_splunk_hec_logs_noack	16.53KiB	0.07	84.46%	23.82MiB	463.41KiB	9.46KiB	0	0.0189942	23.84MiB	331.6KiB	6.77KiB	0	0.0135822	False	False
splunk_hec_to_splunk_hec_logs_acks	8.43KiB	0.03	29.12%	23.76MiB	807.01KiB	16.42KiB	0	0.0331597	23.77MiB	761.21KiB	15.5KiB	0	0.0312673	False	False
splunk_hec_indexer_ack_blackhole	-24.0KiB	-0.1	67.24%	23.77MiB	807.36KiB	16.44KiB	0	0.0331634	23.75MiB	894.55KiB	18.19KiB	0	0.0367811	False	False
file_to_blackhole	-143.55KiB	-0.15	75.41%	95.34MiB	3.63MiB	75.12KiB	0	0.0380393	95.2MiB	4.73MiB	98.27KiB	0	0.0496927	False	False
fluent_elasticsearch	-174.83KiB	-0.21	100.00%	79.47MiB	54.28KiB	1.1KiB	0	0.000666872	79.3MiB	1.58MiB	32.55KiB	0	0.0199375	False	False
http_to_http_json	-54.78KiB	-0.22	99.99%	23.84MiB	340.76KiB	6.96KiB	0	0.0139527	23.79MiB	616.57KiB	12.56KiB	0	0.0253029	False	False
http_pipelines_no_grok_blackhole	-40.58KiB	-0.35	92.09%	11.25MiB	272.7KiB	5.57KiB	0	0.0236649	11.21MiB	1.08MiB	22.42KiB	0	0.0959884	False	False
syslog_splunk_hec_logs	-64.96KiB	-0.37	99.81%	17.12MiB	792.61KiB	16.12KiB	0	0.0451942	17.06MiB	653.8KiB	13.33KiB	0	0.0374177	False	False
http_to_http_noack	-96.43KiB	-0.39	100.00%	23.85MiB	247.16KiB	5.06KiB	0	0.01012	23.75MiB	1.07MiB	22.21KiB	0	0.0448369	False	False
syslog_regex_logs2metric_ddmetrics	-64.51KiB	-0.48	99.99%	13.0MiB	619.93KiB	12.63KiB	0	0.0465563	12.94MiB	538.31KiB	10.98KiB	0	0.0406238	False	False
syslog_log2metric_humio_metrics	-74.99KiB	-0.56	99.97%	13.0MiB	575.75KiB	11.75KiB	0	0.0432435	12.93MiB	836.47KiB	17.02KiB	0	0.0631814	False	False
http_to_http_acks	-174.64KiB	-0.95	54.40%	17.99MiB	7.99MiB	167.01KiB	0	0.444025	17.82MiB	7.88MiB	164.3KiB	0	0.442003	True	True

[tobz]

This generally looks good to me.

I left some non-blocking nits/questions/thoughts, and found one spot you missed when converting examples to use encoding.codec but other than that... 👍🏻

[github-actions]

Soak Test Results

Baseline: 176060c
Comparison: 38a83a0
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison outlier %	comparison CoV	erratic	declared erratic
datadog_agent_remap_blackhole_acks	2.96MiB	4.81	100.00%	61.47MiB	4.65MiB	96.73KiB	0	0.0755481	64.43MiB	3.43MiB	71.79KiB	0	0.0532293	False	False
http_text_to_http_json	1.53MiB	3.97	100.00%	38.66MiB	822.45KiB	16.79KiB	0	0.0207704	40.19MiB	757.06KiB	15.46KiB	0	0.0183896	False	False
datadog_agent_remap_blackhole	2.13MiB	3.32	100.00%	64.06MiB	4.34MiB	90.48KiB	0	0.0677809	66.19MiB	3.07MiB	64.05KiB	0	0.04636	False	False
splunk_hec_route_s3	523.45KiB	2.67	100.00%	19.13MiB	2.24MiB	46.57KiB	0	0.116846	19.65MiB	2.12MiB	44.32KiB	0	0.107781	False	False
syslog_loki	377.96KiB	2.56	100.00%	14.44MiB	478.03KiB	9.77KiB	0	0.0323287	14.81MiB	784.33KiB	15.94KiB	0	0.0517215	False	False
datadog_agent_remap_datadog_logs_acks	442.32KiB	0.7	99.98%	61.55MiB	3.34MiB	69.78KiB	0	0.0541863	61.98MiB	4.69MiB	97.6KiB	0	0.075633	False	False
datadog_agent_remap_datadog_logs	424.43KiB	0.68	100.00%	60.92MiB	830.64KiB	17.01KiB	0	0.0133123	61.34MiB	4.11MiB	85.66KiB	0	0.0670527	False	False
http_to_http_acks	95.5KiB	0.51	30.72%	18.17MiB	8.31MiB	173.78KiB	0	0.457329	18.27MiB	8.04MiB	167.95KiB	0	0.440183	True	True
socket_to_socket_blackhole	45.82KiB	0.33	100.00%	13.62MiB	239.22KiB	4.88KiB	0	0.0171499	13.66MiB	321.33KiB	6.56KiB	0	0.0229612	False	False
splunk_hec_to_splunk_hec_logs_noack	9.06KiB	0.04	58.50%	23.83MiB	432.83KiB	8.84KiB	0	0.0177359	23.84MiB	329.38KiB	6.72KiB	0	0.0134921	False	False
splunk_hec_to_splunk_hec_logs_acks	2.89KiB	0.01	9.50%	23.75MiB	849.08KiB	17.27KiB	0	0.0349037	23.75MiB	836.46KiB	17.02KiB	0	0.0343808	False	False
splunk_hec_indexer_ack_blackhole	672.62B	0	2.11%	23.76MiB	866.25KiB	17.63KiB	0	0.0355976	23.76MiB	857.57KiB	17.45KiB	0	0.03524	False	False
syslog_humio_logs	-2.51KiB	-0.01	17.41%	17.6MiB	514.16KiB	10.5KiB	0	0.028527	17.59MiB	216.83KiB	4.44KiB	0	0.012032	False	False
file_to_blackhole	-31.85KiB	-0.03	30.54%	95.36MiB	2.92MiB	60.62KiB	0	0.0306638	95.33MiB	2.59MiB	53.87KiB	0	0.02714	False	False
http_to_http_json	-34.57KiB	-0.14	99.38%	23.85MiB	334.74KiB	6.83KiB	0	0.013705	23.81MiB	519.19KiB	10.61KiB	0	0.0212872	False	False
fluent_elasticsearch	-179.23KiB	-0.22	100.00%	79.47MiB	68.6KiB	1.39KiB	0	0.000842735	79.3MiB	1.56MiB	32.04KiB	0	0.0196307	False	False
syslog_splunk_hec_logs	-39.27KiB	-0.22	94.95%	17.51MiB	723.7KiB	14.74KiB	0	0.0403438	17.48MiB	668.36KiB	13.63KiB	0	0.0373403	False	False
http_pipelines_blackhole_acks	-2.61KiB	-0.23	56.48%	1.12MiB	126.21KiB	2.57KiB	0	0.110173	1.12MiB	104.57KiB	2.13KiB	0	0.091489	False	False
http_pipelines_blackhole	-5.66KiB	-0.34	98.24%	1.61MiB	46.61KiB	976.01B	0	0.0283034	1.6MiB	107.08KiB	2.18KiB	0	0.0652508	False	False
http_to_http_noack	-104.87KiB	-0.43	100.00%	23.84MiB	407.27KiB	8.33KiB	0	0.0166818	23.73MiB	1.15MiB	23.92KiB	0	0.048344	False	False
syslog_regex_logs2metric_ddmetrics	-58.37KiB	-0.45	99.69%	12.74MiB	700.77KiB	14.28KiB	0	0.05371	12.68MiB	669.73KiB	13.65KiB	0	0.0515623	False	False
syslog_log2metric_splunk_hec_metrics	-183.59KiB	-0.94	100.00%	19.16MiB	550.37KiB	11.22KiB	0	0.028046	18.98MiB	824.03KiB	16.77KiB	0	0.0423879	False	False
http_pipelines_no_grok_blackhole	-118.07KiB	-1.01	100.00%	11.37MiB	377.85KiB	7.71KiB	0	0.0324389	11.26MiB	1.15MiB	23.88KiB	0	0.10188	False	False
syslog_log2metric_humio_metrics	-172.88KiB	-1.27	100.00%	13.34MiB	289.23KiB	5.91KiB	0	0.0211747	13.17MiB	513.54KiB	10.46KiB	0	0.0380787	False	False

[jszwedko]

I mostly scanned through, but nothing jumped out. Just a couple of notes on the upgrade guide, otherwise I think this is good!

[jszwedko]

In the future, it would be useful to call out which code was just moved to try to focus reviews. This could be done in the form of PR comments or separating out refactoring commits.

[pablosichert]

True - I wasn't very considerate about that! Would save quite some time.

[jszwedko]

No worries! I checked first to see if this was new code and found it had just been moved.

[jszwedko]

🎉

[github-actions]

Soak Test Results

Baseline: 7cc3a80
Comparison: d2cb825
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison outlier %	comparison CoV	erratic	declared erratic
datadog_agent_remap_blackhole_acks	2.14MiB	3.38	100.00%	63.27MiB	6.58MiB	137.16KiB	0	0.104035	65.41MiB	3.25MiB	67.92KiB	0	0.0496562	False	False
http_to_http_acks	293.65KiB	1.56	77.65%	18.43MiB	8.17MiB	170.95KiB	0	0.443184	18.72MiB	8.16MiB	170.17KiB	0	0.435765	True	True
syslog_splunk_hec_logs	226.97KiB	1.28	100.00%	17.33MiB	818.18KiB	16.64KiB	0	0.0460951	17.55MiB	683.52KiB	13.93KiB	0	0.0380222	False	False
syslog_regex_logs2metric_ddmetrics	128.34KiB	0.97	100.00%	12.88MiB	673.22KiB	13.71KiB	0	0.051028	13.01MiB	602.34KiB	12.28KiB	0	0.0452159	False	False
syslog_humio_logs	129.43KiB	0.73	100.00%	17.42MiB	159.31KiB	3.25KiB	0	0.00892923	17.55MiB	172.28KiB	3.53KiB	0	0.00958648	False	False
datadog_agent_remap_blackhole	70.81KiB	0.11	52.97%	64.59MiB	4.41MiB	91.83KiB	0	0.068241	64.66MiB	1.65MiB	34.42KiB	0	0.0254749	False	False
splunk_hec_to_splunk_hec_logs_noack	11.14KiB	0.05	69.22%	23.83MiB	425.81KiB	8.7KiB	0	0.0174483	23.84MiB	323.84KiB	6.61KiB	0	0.0132639	False	False
socket_to_socket_blackhole	2.49KiB	0.02	54.99%	13.71MiB	121.66KiB	2.48KiB	0	0.00866238	13.71MiB	106.21KiB	2.17KiB	0	0.00756084	False	False
splunk_hec_to_splunk_hec_logs_acks	4.55KiB	0.02	15.08%	23.75MiB	843.01KiB	17.15KiB	0	0.0346536	23.76MiB	821.55KiB	16.71KiB	0	0.0337649	False	False
splunk_hec_indexer_ack_blackhole	-976.87B	-0	3.09%	23.76MiB	850.44KiB	17.31KiB	0	0.0349468	23.76MiB	858.78KiB	17.48KiB	0	0.0352911	False	False
http_text_to_http_json	-3.64KiB	-0.01	11.51%	38.49MiB	920.37KiB	18.79KiB	0	0.0233436	38.49MiB	818.69KiB	16.72KiB	0	0.0207666	False	False
file_to_blackhole	-53.87KiB	-0.06	39.21%	95.34MiB	3.38MiB	70.04KiB	0	0.0354303	95.29MiB	3.76MiB	78.22KiB	0	0.0394507	False	False
syslog_log2metric_splunk_hec_metrics	-22.63KiB	-0.13	80.31%	17.48MiB	472.74KiB	9.64KiB	0	0.0263984	17.46MiB	719.7KiB	14.65KiB	0	0.0402399	False	False
http_to_http_json	-34.16KiB	-0.14	99.31%	23.85MiB	337.95KiB	6.9KiB	0	0.0138365	23.81MiB	518.5KiB	10.59KiB	0	0.0212587	False	False
http_to_http_noack	-51.53KiB	-0.21	97.02%	23.82MiB	608.3KiB	12.43KiB	0	0.0249338	23.77MiB	990.73KiB	20.19KiB	0	0.0406956	False	False
fluent_elasticsearch	-178.91KiB	-0.22	100.00%	79.47MiB	54.3KiB	1.1KiB	0	0.000667043	79.3MiB	1.66MiB	34.1KiB	0	0.0208803	False	False
http_pipelines_blackhole_acks	-3.61KiB	-0.3	85.47%	1.17MiB	89.83KiB	1.83KiB	0	0.0749653	1.17MiB	82.2KiB	1.68KiB	0	0.0688115	False	False
datadog_agent_remap_datadog_logs_acks	-532.09KiB	-0.81	100.00%	63.85MiB	2.69MiB	56.19KiB	0	0.0420416	63.33MiB	4.5MiB	93.61KiB	0	0.0709895	False	False
http_pipelines_blackhole	-14.79KiB	-0.92	100.00%	1.57MiB	53.63KiB	1.1KiB	0	0.03339	1.55MiB	106.86KiB	2.18KiB	0	0.0671459	False	False
datadog_agent_remap_datadog_logs	-651.27KiB	-0.99	100.00%	63.93MiB	495.69KiB	10.14KiB	0	0.00756999	63.3MiB	4.37MiB	91.02KiB	0	0.0690502	False	False
syslog_log2metric_humio_metrics	-171.07KiB	-1.28	100.00%	13.08MiB	447.21KiB	9.13KiB	0	0.0333727	12.92MiB	534.03KiB	10.88KiB	0	0.040367	False	False
splunk_hec_route_s3	-331.17KiB	-1.71	100.00%	18.88MiB	2.26MiB	47.01KiB	0	0.119603	18.56MiB	2.25MiB	47.15KiB	0	0.121493	False	False
http_pipelines_no_grok_blackhole	-212.64KiB	-1.81	100.00%	11.45MiB	123.93KiB	2.53KiB	0	0.0105683	11.24MiB	1.09MiB	22.76KiB	0	0.0972234	False	False
syslog_loki	-278.29KiB	-1.81	100.00%	14.98MiB	315.26KiB	6.45KiB	0	0.0205419	14.71MiB	731.07KiB	14.86KiB	0	0.0485155	False	False