Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-core): update TabItem and TabList components to v2 #8047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OlivierFL
Copy link
Collaborator

Description

  • Update component name and CSS to match new component guidelines
  • Update component usages in XO 6 and XO Lite

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@OlivierFL OlivierFL self-assigned this Oct 11, 2024
selected?: boolean
tag?: string
}>(),
{ tag: 'span', disabled: undefined }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of assigning undefined as the default value?
Is it to prevent vue from converting undefined to false?
If so, is there any point in having undefined instead of false here?
Or maybe this is something I missed in the guideline?
In that case, why selected is not handled?

Comment on lines +16 to +20
defineProps<{
disabled?: boolean
selected?: boolean
tag?: string
}>(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DS, i can see a counter prop.

@@ -1,6 +1,6 @@
<!-- v1.0 -->
<!-- v2 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the Tabs bar changelog, the v2 implement the scroll bar option

@@ -22,7 +22,7 @@ export function useTabList<TName extends string>(names: TName[], initialTab?: Ma
event.preventDefault()
activate(name)
},
active: isActive(name),
selected: isActive(name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selected: isSelected(name) maybe? In order to sync name. (or isCurrent() if the proposition is accepted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants