Xo tasks @xo/backups

[b-Nollet]

Description

Replacing backup tasks by tasks from @vates/task in @xen-orchestra/backups.

Merge this to branch backup-XO-Tasks instead of master, as it must not be merged before further changes are made.

Checklist

• Commit
  • Title follows commit conventions
  • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
  • If bug fix, add Introduced by
• Changelog
  • If visible by XOA users, add changelog entry
  • Update "Packages to release" in CHANGELOG.unreleased.md
• PR
  • If UI changes, add screenshots
  • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

• develop skills of junior reviewers
• limit the workload for senior reviewers
• limit the number of unnecessary changes by the author

1. The author creates a PR.
2. Review process:
   1. The author assigns the junior reviewer.
   2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
   3. The junior reviewer assigns the senior reviewer.
   4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

1. The author can request a review at any time, even if the PR is still a Draft.
2. In theory, there should not be more than one reviewer at a time.
3. The author should not make any changes:
   • When a reviewer is assigned.
   • Between the junior and senior reviews.

[MathieuRA]

I don't know if this is normal, since the work will be split into multiple PRs, but log.tasks doesn't exist anymore, and this breaks the UI.

{
  "data": {
    "mode": "delta",
    "reportWhen": "failure"
  },
  "id": "1727783877606",
  "jobId": "d78a6445-1c59-4932-9851-d6c642e46c21",
  "jobName": "8.2 non smart mode",
  "message": "backup",
  "scheduleId": "464e7258-3559-4716-aa3e-743c85bd89c9",
  "start": 1727783877606,
  "status": "success",
  "end": 1727783897166
}

[fbeauchamp]

please rework the retry task handling

[fbeauchamp]

shouldn't we use runInside here to ensure we don't lose an error ?

[b-Nollet]

The only difference using runInside would make is that the task would stay pending if it doesn't have an error, so it's not a solution.
If we want the backup to fail when one subtask fails, we would have to remove the .catch(noop), but it would need some testing as it may have other consequences.

[b-Nollet]

I don't know if this is normal, since the work will be split into multiple PRs, but log.tasks doesn't exist anymore, and this breaks the UI.

{
  "data": {
    "mode": "delta",
    "reportWhen": "failure"
  },
  "id": "1727783877606",
  "jobId": "d78a6445-1c59-4932-9851-d6c642e46c21",
  "jobName": "8.2 non smart mode",
  "message": "backup",
  "scheduleId": "464e7258-3559-4716-aa3e-743c85bd89c9",
  "start": 1727783877606,
  "status": "success",
  "end": 1727783897166
}

Yes, backup tasks and vates tasks handle logs differently, it will be dealt with later

[MathieuRA]

Suggested change

	// error has to be caught in the taskto prevent in failure, but handled outside the task to execute another task.run()
	// error has to be caught in the task to prevent in failure, but handled outside the task to execute another task.run()

[MathieuRA]

Suggested change

	if (taskError) {
	if (taskError !== undefined) {

[MathieuRA]

To avoid nested if/else, i suggest something like that:

// NOT TESTED
return task.runInside(async () => {
  let result
  try {
    result = await vmBackup.run()
  } catch (error) {
    taskError = error
  }

  if (taskError === undefined) {
    return task.run(() => result)
  }

  if (isLastRun) {
    return task.run(() => {
      throw taskError
    })
  }

  task.warning(`Retry the VM mirror backup due to an error`, {
    attempt: nTriesByVmId[vmUuid],
    error: taskError.message,
  })
  queue.add(vmUuid)
})

[b-Nollet]

Suggested change

	// error has to be caught in the taskto prevent in failure, but handled outside the task to execute another task.run()
	// error has to be caught in the taskto prevent its failure, but handled outside the task to execute another task.run()

[b-Nollet]

Suggested change

	// error has to be caught in the taskto prevent in failure, but handled outside the task to execute another task.run()
	// error has to be caught in the task to prevent its failure, but handled outside the task to execute another task.run()