Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 and pylint with ruff #416

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

jongbinjung
Copy link
Collaborator

In case we're still interested in #337

Tried my best to accommodate existing code style.

Also added review dog to github actions, so that it's easier to see broken things in the PR directly

Copy link

Coverage after merging jb/use-ruff into master will be

99.44%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%

Copy link

Coverage after merging jb/use-ruff into master will be

99.44%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%

Copy link

Coverage after merging jb/use-ruff into master will be

99.44%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_polygon_class.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%
   test_numpy_int.py100%100%100%100%

Copy link

Coverage after merging jb/use-ruff into master will be

99.43%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_polygon_class.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%
   test_numpy_int.py100%100%100%100%

Copy link

Coverage after merging jb/use-ruff into master will be

99.43%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_polygon_class.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%
   test_numpy_int.py100%100%100%100%

Copy link
Contributor

@ajfriend ajfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like adding ruff! And I can mess with the style options later :)

I'm not familiar with review dog. Despite the nice onomatopoeic pairing, can we split out the review dog change to a different PR?

Copy link

Coverage after merging jb/use-ruff into master will be

99.43%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
tests
   test_cells_and_edges.py100%100%100%100%
   test_error_codes.py100%100%100%100%
   test_h3.py100%100%100%100%
   test_length_area.py100%100%100%100%
   util.py100%100%100%100%
tests/polyfill
   test_h3.py100%100%100%100%
   test_polyfill.py100%100%100%100%
   test_polyfill_ordering.py100%100%100%100%
   test_polygon_class.py100%100%100%100%
   test_to_multipoly.py100%100%100%100%
tests/test_apis
   test_basic_int.py100%100%100%100%
   test_basic_str.py100%100%100%100%
   test_collection_inputs.py100%100%100%100%
   test_numpy_int.py100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants