Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Update matching handlers to return TaskListPartitionConfig in responses #6376

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shaddoll
Copy link
Contributor

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 57.61589% with 64 lines in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (877ccae) to head (32b9f81).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
service/matching/tasklist/task_list_manager.go 34.00% 33 Missing ⚠️
service/matching/handler/engine.go 70.17% 15 Missing and 2 partials ⚠️
service/matching/tasklist/db.go 54.83% 13 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/data_manager_interfaces.go 94.91% <100.00%> (+0.20%) ⬆️
service/matching/handler/handler.go 100.00% <100.00%> (ø)
service/matching/tasklist/db.go 75.00% <54.83%> (+4.75%) ⬆️
service/matching/handler/engine.go 82.61% <70.17%> (-0.07%) ⬇️
service/matching/tasklist/task_list_manager.go 64.87% <34.00%> (-2.99%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b75b7d...32b9f81. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant