Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pending tasks count in Workflow History tab #698

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Show pending tasks count in Workflow History tab #698

merged 5 commits into from
Oct 17, 2024

Conversation

adhityamamallan
Copy link
Contributor

@adhityamamallan adhityamamallan commented Oct 17, 2024 •
edited
Loading

Summary

  • Modify PageTabs to show an optional end enhancer
  • Show pending tasks count in Workflow History tab for workflows with at least 1 pending task
  • Create useDescribeWorkflow hook as a wrapper around useSuspenseQuery for the Describe Workflow endpoint
    • Replace existing usages with the new hook
    • Rename Refresh Interval to Refetch Interval, to be consistent with React Query naming

Test Plan

Unit tests + ran locally.

Screenshot 2024-10-17 at 2 48 02 PM

@Assem-Uber Assem-Uber merged commit ba1352c into uber:release/4.0.0 Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhityamamallan @Assem-Uber