Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timeout events status #695

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix timeout events status #695

merged 2 commits into from
Oct 15, 2024

Conversation

Assem-Hafez
Copy link
Contributor

Issue Description

  • Status of timed out events are showing as running instead of timed out.
  • Also found that details is failing to get parsed correctly.

Fix

  • Added workflowExecutionTimedOutEventAttributes to the completed events set.
  • auto parse version to sting to avoid parsing issues if version is returned as numeric value from API.

Screenshots

Before the fix
Screenshot 2024-10-15 at 21 04 56

After the fix
Screenshot 2024-10-15 at 21 06 24

timl3136
timl3136 approved these changes Oct 15, 2024
View reviewed changes
Copy link

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Assem-Uber Assem-Uber merged commit 6ffb42d into uber:release/4.0.0 Oct 15, 2024
6 checks passed
@Assem-Hafez Assem-Hafez deleted the bugfix/11119/fix-timeout-events branch October 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timl3136 timl3136 timl3136 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Assem-Hafez @timl3136 @Assem-Uber