Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO_NOT_MERGE] Make RibEvents' MutableSharedFlows buffers configurable. #642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

psteiger
Copy link
Contributor

No description provided.

/**
* Sets the extra buffer capacity for [routerEventsFlow] and [ribActionEventsFlow].
*
* This function must be called on the main thread, and before any usage of:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if this isn't true? How can we guarantee it's called before?

Copy link
Contributor Author

@psteiger psteiger Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyvsmith

What will happen if this isn't true?

Then, the original value (UNLIMITED) will be used at the moment someone calls one of the RibEvents flow / observable.

How can we guarantee it's called before?

I propose we just do it on our Application.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the earliest we can safely fetch a param? Do we ever call this prior?

Copy link
Contributor Author

@psteiger psteiger Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyvsmith

What's the earliest we can safely fetch a param?

It seems we'll just have to bite that first session with some default value, and have the new configuration for the next app starts.

Do we ever call this prior?

No, I don't think there's any access to RibEvents flow before Application.onCreate. AFAIK only ContentProvider can run before, and we don't have any touching RibEvents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants