Remove intrinsics usage in RibCoroutineWorker
#627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyvsmith
approved these changes
Feb 20, 2024
This commit changes dispatching logic to a much simpler one that does not require usage of intrinsics. In order to synchronously get an instance of `bindJob`, we start the `unbindJob` coroutine undispatched (`bindJob` is a child of `unbindJob`, so we need an instance of `unbindJob` to create an instance of `bindJob`). After saving `bindJob`, we properly dispatch in a cancellable way by simply `launch`ing a new coroutine.
psteiger
force-pushed
the
simplify-rrw
branch
from
7efa522
to
4b2df0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we need to build both
bindJobandunbindJobsynchronously (CoroutineScope.bindis not suspending and must return a handle with both jobs).In order to synchronously get an instance of
bindJob, we start theunbindJobcoroutine undispatched (bindJobis a child ofunbindJob, so we need an instance ofunbindJobto create an instance ofbindJob).This commit changes dispatching logic to a much simpler one that does not require usage of intrinsics: after saving
bindJob, we properly dispatch in a cancellable way by simplylaunching a new coroutine.