Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from deprecated @JvmDefault to compiler option -Xjvm-default=all #576

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Migrate from deprecated @JvmDefault to compiler option -Xjvm-default=all #576

merged 1 commit into from
Jul 17, 2023

Conversation

psteiger
Copy link
Contributor

@psteiger psteiger commented May 10, 2023 •
edited
Loading

Docs state that:

If you used the @JvmDefault annotation before, you can safely remove it and use one of the new modes. If you already used -Xjvm-default=enable, which generated only the default method implementations, you can now replace it with -Xjvm-default=all.

Fixes #571

@psteiger psteiger marked this pull request as draft May 10, 2023 14:20
@tyvsmith tyvsmith added the Android Android related tickets label May 12, 2023
@psteiger psteiger marked this pull request as ready for review May 14, 2023 19:08
@tyvsmith
Copy link
Member

I believe there was an issue with regards to Bazel and this setting before. @jbarr21 @oliviernotteghem do you recall?

@psteiger
Copy link
Contributor Author

psteiger commented May 16, 2023 •
edited
Loading

I believe there was an issue with regards to Bazel and this setting before. @jbarr21 @oliviernotteghem do you recall?

Probably this issue opened by @oliviernotteghem himself?

Should it matter for this project though? I understand Bazel will consume this library as an already-compiled binary, as opposed to building it. Bytecode will already be generated. Unless I'm missing something, so I'll wait for their input.

@oliviernotteghem
Copy link
Contributor

@psteiger : please refer to this PR for context on the issue @tyvsmith is referring to. I can help you verify changes you may make are compatible with Bazel (or you can simply build with Bazel a simple Android binary target having a dependencies on RIBs libraries)

@jbarr21
Copy link
Contributor

jbarr21 commented Jul 15, 2023

This will be needed in order to compile against Kotlin 1.9

@jbarr21 jbarr21 self-requested a review July 17, 2023 19:13
@psteiger
Migrate from deprecated @JvmDefault to compiler option `-Xjvm-default…
67be177 
…=all`

Docs state that:

> If you used the @JvmDefault annotation before, you can safely remove it and use one of the new modes. If you already used -Xjvm-default=enable, which generated only the default method implementations, you can now replace it with -Xjvm-default=all.
@psteiger psteiger merged commit 36d2c13 into uber:main Jul 17, 2023
1 check passed
@psteiger psteiger deleted the jvmdefault-all branch July 17, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbarr21 jbarr21 jbarr21 approved these changes

@FranAguilera FranAguilera Awaiting requested review from FranAguilera

@tyvsmith tyvsmith Awaiting requested review from tyvsmith

Assignees
No one assigned
Labels
Android Android related tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from deprecated @JvmDefault and -Xjvm-default=enabled to -Xjvm-default=all
4 participants
@psteiger @tyvsmith @oliviernotteghem @jbarr21