Use core-annotated method approach instead of renaming

uber · Oct 31, 2023 · 43f27d3 · 43f27d3
1 parent 28ffde2
commit 43f27d3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/android/libraries/rib-android/src/main/kotlin/com/uber/rib/core/RibActivity.kt b/android/libraries/rib-android/src/main/kotlin/com/uber/rib/core/RibActivity.kt
@@ -104,7 +104,7 @@ public abstract class RibActivity :
   override fun onSaveInstanceState(outState: android.os.Bundle) {
     super.onSaveInstanceState(outState)
     _callbacksFlow.tryEmit(createOnSaveInstanceStateEvent(outState))
-    router?.dispatchSaveInstanceState(Bundle(outState))
+    router?.saveInstanceStateInternal(Bundle(outState))
       ?: throw NullPointerException("Router should not be null")
   }
 

diff --git a/android/libraries/rib-android/src/main/kotlin/com/uber/rib/core/ViewRouter.kt b/android/libraries/rib-android/src/main/kotlin/com/uber/rib/core/ViewRouter.kt
@@ -47,8 +47,4 @@ abstract class ViewRouter<V : View, I : Interactor<*, *>> : Router<I> {
       XRay.apply(this, view)
     }
   }
-
-  internal fun dispatchSaveInstanceState(outState: Bundle) {
-    saveInstanceState(outState)
-  }
 }
diff --git a/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/Router.kt b/android/libraries/rib-base/src/main/kotlin/com/uber/rib/core/Router.kt
@@ -229,7 +229,8 @@ protected constructor(
     return children
   }
 
-  internal fun saveInstanceStateInternal(outState: Bundle) {
+  @CoreFriendModuleApi
+  public fun saveInstanceStateInternal(outState: Bundle) {
     saveInstanceState(outState)
   }