Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reuse capacity when possible in <BytesMut as Buf>::advance impl" #726

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Aug 1, 2024

Too much code relies on this behavior. We can't change it.

Closes: #725

Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of it so quickly!

@Darksonn Darksonn merged commit f488be4 into master Aug 1, 2024
15 checks passed
@Darksonn Darksonn deleted the alice/revert-advance-reuse branch August 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BytesMut::advance no longer advances cursor
4 participants