Update to latest iPXE #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves tinkerbell#117 Relates to tinkerbell#115 This release includes ipxe/ipxe#1152 which resolves tinkerbell#117 I've also included the workaround for tinkerbell#115 as specified from ipxe/ipxe#1091 (comment) Signed-off-by: Nahum Shalman <[email protected]>
nshalman
force-pushed
the
updates-20240227
branch
from
ec86736
to
7f6cde1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 97.28% 97.82% +0.53%
==========================================
Files 5 5
Lines 442 367 -75
==========================================
- Hits 430 359 -71
+ Misses 8 4 -4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
Forgot to revert the patching in of the certificates... Need a bit more testing to confirm and will update this PR. |
|
Let me know if you want the changes in 7f6cde1 split into more than one commit. |
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to the latest iPXE
This release includes ipxe/ipxe#1152 which resolves #117.
I've also included the workaround for #115 as specified from ipxe/ipxe#1091 (comment) to keep Mellanox cards working.
Why is this needed
Fixes: #117
Relates to: #115
How Has This Been Tested?
I am drafting this PR as the first step towards testing. The plan is: