*: move tso to independent thread #8720
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/L
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
client/client.go
Outdated
| @@ -203,7 +203,9 @@ func (k *serviceModeKeeper) close() { | |||
| defer k.Unlock() | |||
| switch k.serviceMode { | |||
| case pdpb.ServiceMode_API_SVC_MODE: | |||
| k.tsoSvcDiscovery.Close() | |||
| if k.tsoSvcDiscovery != nil { | |||
There was a problem hiding this comment.
What about moving this check into Close()?
server/cluster/cluster.go
Outdated
| @@ -390,25 +400,85 @@ func (c *RaftCluster) checkServices() { | |||
| } | |||
| } | |||
|
|
|||
| // checkTSOService checks the TSO service. | |||
| func (c *RaftCluster) checkTSOService() { | |||
| if !c.isAPIServiceMode { | |||
There was a problem hiding this comment.
| if !c.isAPIServiceMode { | |
| if c.isAPIServiceMode { | |
| return | |
| } |
server/cluster/cluster.go
Outdated
| if !c.isAPIServiceMode { | ||
| if c.member.IsLeader() { | ||
| if err := c.startTSOJobs(); err != nil { | ||
| // If there is an error, need to wait for the next check. |
server/cluster/cluster.go
Outdated
| } else { | ||
| // leader exits, reset the allocator group | ||
| if err := c.stopTSOJobs(); err != nil { | ||
| // If there is an error, need to wait for the next check. |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
|
/retest |
|
@rleungx: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -314,11 +322,13 @@ func (c *RaftCluster) Start(s Server) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| c.checkTSOService() | |||
There was a problem hiding this comment.
Can we put this func next to checkSchedulingService?
| @@ -1715,29 +1714,6 @@ func (s *Server) campaignLeader() { | |||
| s.member.KeepLeader(ctx) | |||
| log.Info(fmt.Sprintf("campaign %s leader ok", s.mode), zap.String("campaign-leader-name", s.Name())) | |||
|
|
|||
| if !s.IsAPIServiceMode() { | |||
There was a problem hiding this comment.
Need we remove the comments? L1714, L1703-L1706
What problem does this PR solve?
Issue Number: Ref #8477.
What is changed and how does it work?
This is a part of #8517.
Check List
Tests
Release note