join, etcdutil: enable linearizable in MemberList #8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/M
lhy1024
commented
Aug 22, 2024
| @@ -174,8 +175,15 @@ func PrepareJoinCluster(cfg *config.Config) error { | |||
| listSucc bool | |||
| ) | |||
|
|
|||
| // If there is only one member in the cluster, the cluster maybe lost leader | |||
| // since quorum is not active after adding the new member. | |||
| linearizable := true | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8564 +/- ##
==========================================
- Coverage 77.64% 77.63% -0.01%
==========================================
Files 474 474
Lines 61877 61884 +7
==========================================
+ Hits 48044 48045 +1
- Misses 10300 10305 +5
- Partials 3533 3534 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/test pull-integration-realcluster-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8542
What is changed and how does it work?
Check List
Tests
Release note