Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Preventing Duplicate Migrations on the Same Shard #580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prathamesh000777
Copy link

Issue
Currently, the migration process runs multiple times on a given shard due to how shards are fetched and processed. This occurs because the list of shards is obtained using the expression migrations.map(&:shards).flatten.map(&:to_s), resulting in an array of shard names. As a consequence, if a shard has 'n' associated migrations, the migration process will be executed 'n' times on that shard.

Proposed Solution
To address this issue and ensure that migrations are not duplicated on the same shard, we can modify the process as follows:

Instead of directly flattening the migrations.map(&:shards) array, we get unique elements migrations.map(&:shards).uniq.

This approach guarantees that each shard will only appear once in the resulting array, preventing duplicate migrations on the same shard.

Benefits
Improves the efficiency of the migration process by preventing unnecessary repeated migrations on the same shard.

use unique shards for Octopus::Migrator#send_queries_to_multiple_shards
version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant