Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a docker development environment #526

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

calh
Copy link

@calh calh commented Jun 25, 2019

Hi @thiagopradi,

I'll submit another PR later for addressing a bug I found in octopus. For now, I wanted to contribute a docker compose system to make it easier for developers to dive into patches on your project. I was struggling with the mysql and postgres setups without passwords, and Docker seemed like the way to go here.

I've added instructions to the README on how to get started with development. The docker-compose.yml will load up mysql, postgres, and run the test suite when starting up the stack.

Let me know if you have any questions or concerns!

calh added 3 commits June 21, 2019 15:38
Running cucumber gives the error:

cannot load such file -- test/unit (LoadError)
These weren't supposed to make it into this PR
@thiagopradi
Copy link
Owner

@calh - this looks awesome! I'm on a pretty busy week - but I'll review this PR this weekend.

done

# Not working...
bundle exec cucumber
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to get the sample_app to run, but cucumber fails with:

Deprecated: Found tags option '~@wip'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/values/time_zone.rb:270: warning: circular argument reference - now
The PGconn, PGresult, and PGError constants are deprecated, and will be
removed as of version 1.0.

You should use PG::Connection, PG::Result, and PG::Error instead, respectively.

Called from /usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:236:in `load_dependency'
cannot load such file -- test/unit (LoadError)
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `block in require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:236:in `load_dependency'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/railties-3.2.13/lib/rails/test_help.rb:5:in `<top (required)>'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `block in require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:236:in `load_dependency'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/activesupport-3.2.13/lib/active_support/dependencies.rb:251:in `require'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-rails-1.4.5/lib/cucumber/rails.rb:11:in `<top (required)>'
/usr/src/app/sample_app/features/support/env.rb:7:in `require'
/usr/src/app/sample_app/features/support/env.rb:7:in `<top (required)>'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/glue/registry_and_more.rb:107:in `load'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/glue/registry_and_more.rb:107:in `load_code_file'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime/support_code.rb:144:in `load_file'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime/support_code.rb:85:in `block in load_files!'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime/support_code.rb:84:in `each'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime/support_code.rb:84:in `load_files!'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime.rb:272:in `load_step_definitions'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/runtime.rb:68:in `run!'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/lib/cucumber/cli/main.rb:34:in `execute!'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/gems/cucumber-3.1.2/bin/cucumber:9:in `<top (required)>'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/bin/cucumber:23:in `load'
/usr/src/app/sample_app/.bundle/ruby/2.5.0/bin/cucumber:23:in `<top (required)>'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli/exec.rb:74:in `load'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli/exec.rb:74:in `kernel_load'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli/exec.rb:28:in `run'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli.rb:463:in `exec'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli.rb:27:in `dispatch'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/cli.rb:18:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.17.3/exe/bundle:30:in `block in <top (required)>'
/usr/local/lib/ruby/site_ruby/2.5.0/bundler/friendly_errors.rb:124:in `with_friendly_errors'
/usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.17.3/exe/bundle:22:in `<top (required)>'
/usr/local/bundle/bin/bundle:23:in `load'
/usr/local/bundle/bin/bundle:23:in `<main>'
root@601d44653d95:/usr/src/app/sample_app# 

I'm not well versed on cucumber, so I'm not sure what to do here...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calh - the build is probably broken on the sample_app for a while - I think you can ignore this cucumber process for now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants