Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable auth for the endpoints with support #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Jan 6, 2023

Motivation

Each endpoint must support the IdentityApi. We have a few custom plugins which do not yet appear to support it. This enables auth on any of the endpoints that appear to support it.

I think this should land after #185, but I don't believe it technically matters.

Approach

Add an authMiddleware.ts and cookieAuth as per the community docs.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

⚠️ No Changeset found

Latest commit: 3879588

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jbolda jbolda force-pushed the auth-backend-routes-with-support branch from 1869f85 to 3879588 Compare January 6, 2023 15:36
@frontsidejack
Copy link
Member

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

@jbolda jbolda mentioned this pull request Jan 6, 2023
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@@ -17,6 +17,9 @@ auth:
# see https://backstage.io/docs/auth/ to learn about auth providers
session:
secret: ${AUTH_SESSION_CLIENT_SECRET}
# see https://backstage.io/docs/auth/service-to-service-auth#setup
keys:
- secret: ${BACKEND_SECRET}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want to confirm that we have this token set.

Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbolda
Copy link
Contributor Author

jbolda commented Feb 6, 2023

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants