Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for jsonschema.Struct in requests #110

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

vearutop
Copy link
Member

Fixes #109.

Copy link

github-actions bot commented May 20, 2024

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 21 3964 (+8) 2953 (+6) 214 797 (+2) 807 (+4) 91.1K (+297B)
Go (test) 22 6203 (+172) 4715 (+154) 660 828 (+18) 59 160.2K (+3.8K)

Copy link

Go API Changes

# summary
Inferred base version: v0.2.50
Suggested version: v0.2.51

Copy link

Unit Test Coverage

total: (statements) 45.6%
changed lines: (statements) 66.7%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 66.7%
internal/json_schema.go 66.7%
internal/json_schema.go:36 ReflectRequestBody 0.0%
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 45.6% 45.6% (0.0%)
internal/json_schema.go ReflectRequestBody 95.4% 95.7% (+0.3%)

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.94%. Comparing base (eaa1394) to head (37b853f).

Current head 37b853f differs from pull request most recent head 95054a7

Please upload reports for the commit 95054a7 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   39.91%   39.94%   +0.03%     
==========================================
  Files          16       16              
  Lines        6597     6601       +4     
==========================================
+ Hits         2633     2637       +4     
  Misses       3497     3497              
  Partials      467      467              
Flag Coverage Δ
unittests 39.94% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop merged commit 28402d8 into master May 20, 2024
6 checks passed
@vearutop vearutop deleted the jschema-struct-req branch May 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setupRequest doesn't work with jsonschema.Struct
1 participant