Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Commit

Permalink
u
Browse files Browse the repository at this point in the history
  • Loading branch information
jsantell committed Nov 17, 2023
1 parent 127e44e commit c40e088
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions .github/workflows/run_test_suite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,6 @@ jobs:
shell: sh
run: |
choco install -y cmake protoc openssl
# Increase stack size on Windows tests; (non-main) threads are spawned with 2MB
# default stack size, which `orb_can_render_peers_in_the_sphere_address_book`
# uses (at time of writing) slightly more than 2MB. While we could set the thread
# stack size at runtime (via tokio's `thread_stack_size`), it appears to not solve the
# problem, possibly due to the harness thread overflowing (e.g. a non-main thread that
# we can't configure within the test). In lieu of that, set RUST_MIN_STACK to increase
# the stack sizes of threads created by tokio within tests, as well as the test harness
# threads themselves.
#
# While our main thread isn't under fire here, notating this for future use:
# https://users.rust-lang.org/t/stack-overflow-when-compiling-on-windows-10/50818/8
export RUST_MIN_STACK=4000000
- name: 'Install environment packages (Linux)'
if: ${{ matrix.platform == 'ubuntu-latest' }}
run: |
Expand Down Expand Up @@ -122,6 +109,21 @@ jobs:
FEATURES="--features ${{matrix.features}}"
fi
# Increase stack size on Windows tests; (non-main) threads are spawned with 2MB
# default stack size, which `orb_can_render_peers_in_the_sphere_address_book`
# uses (at time of writing) slightly more than 2MB. While we could set the thread
# stack size at runtime (via tokio's `thread_stack_size`), it appears to not solve the
# problem, possibly due to the harness thread overflowing (e.g. a non-main thread that
# we can't configure within the test). In lieu of that, set RUST_MIN_STACK to increase
# the stack sizes of threads created by tokio within tests, as well as the test harness
# threads themselves.
#
# While our main thread isn't under fire here, notating this for future use:
# https://users.rust-lang.org/t/stack-overflow-when-compiling-on-windows-10/50818/8
if [ "${{matrix.platform}}" = "windows-latest" ]; then
export RUST_MIN_STACK=4000000
fi
cargo +${{ matrix.toolchain }} nextest run $FEATURES --retries 5 --color always 2>&1 | tee test-results/log
env:
NOOSPHERE_LOG: academic
Expand Down

0 comments on commit c40e088

Please sign in to comment.