[Bugfix] Fix the html_element tag with Twig 3.9.0
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twig 3.9.0 introduced a new `yield` usage, breaking the `html_element` tag node. See twigphp/Twig#4039.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
=============================================
+ Coverage 95.83% 96.61% +0.77%
- Complexity 51 52 +1
=============================================
Files 7 7
Lines 144 177 +33
=============================================
+ Hits 138 171 +33
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
titouanmathis
force-pushed
the
bugfix/twig-3.9-html_element
branch
from
8f467e3
to
ad102e7
Compare
titouanmathis
force-pushed
the
bugfix/twig-3.9-html_element
branch
from
007b05c
to
b094d09
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new yield mode for output generation introduced in Twig 3.9.0 breaks our custom
html_elementtag.This PR fixes this bug by using the new
NodeCaptureclass if it exists to get the body of the tag.