Remove .vscode folders that were probably commited by mistake #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvsch
commented
Aug 31, 2023
Comment on lines
+10
to
+13
| # Ignore vscode config folder, except in specific templates | ||
| .vscode | ||
| !/gsap-svelte/.vscode | ||
| !/quasar/.vscode |
There was a problem hiding this comment.
Erring on the side of ignoring all .vscode folders so we don't accidentally commit them, but listing exceptions for templates where we want to commit them.
sulco
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
.vscodefolders in 4 templates:In two templates (
eggandslidev), these look like the generic.vscode/settings.jsonfile generated by the StackBlitz classic editor when clicking the “Workspace Settings” button. (IMHO this button should not generate a file that gets saved, and/or should be removed, because it leads to a lot of useless cruft in our users's projects… and apparently in our own starter projects too.)In two templates (
gsap-svelteandquasar), they mostly contain deliberate lists of extensions. I erred on the side of keeping them, though I'm not sure why we would have them for those templates and not for others. Looking at the Vite templates, they don't have.vscodefolders except for the Svelte and Vue templates, so again it's a mixed bag.