[ssh] Stop collecting 'ls' information from non-local home dirs #3807
Conversation
|
This is a different approach to what I was trying to solve in #3490 and I opened a new PR to keep both approaches separated. I tried to find if we gather this info in other places, but I could only find the function _get_devices_by_fstype() that I think is slightly different. Would it make sense to create a _get_mounted_fstypes() or similar in sos/report/init.py and call that from the ssh (and other) plugins? |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
The change makes sense; maybe worth having an option to keep current behaviour..? (no idea how useful it would be, though). Will this PR make #3490 obsolete? |
I thought about that, but I keep being told that the reward for getting this info is not worth the slowness running sos that we get when going through NFS filesystems
Yes, I'll keep open only the one that you all agree it's a better approach. |
| # Read the home paths of users in the system and check the ~/.ssh dirs | ||
| for user in users_data: | ||
| if user.pw_dir in fs_mount_info and \ | ||
| fs_mount_info[user.pw_dir] in non_local_fs: | ||
| continue |
There was a problem hiding this comment.
We should log something so that end users aren't left wondering why this wasn't collected when previously they may have been expecting it.
There was a problem hiding this comment.
What verbosity level? Info? (or debug? isnt it too hidden..?)
There was a problem hiding this comment.
With warn I get this:
Setting up archive ...
Setting up plugins ...
[plugin:ssh] Skipping capture in /home/jcastill because it's a remote directory
Running plugins. Please wait ...
Starting 1/1 ssh [Running: ssh]
There was a problem hiding this comment.
Yeah, and I dont know if that is not too "vocal". I think info verbosity is the best, but I am ok with any.
There was a problem hiding this comment.
You are right, in the specific scenario of tens or hundreds of NFS mounted homedirs, the output would be huge.
There was a problem hiding this comment.
So the verbosity should not be warning, right..?
There was a problem hiding this comment.
Exactly. I'm pushing a change with info now
jcastill
force-pushed
the
jcastillo-capture-ssh-userconfs-only-local
branch
2 times, most recently
from
dea08ef
to
7eef06b
Compare
Commands like 'ls -laZ' can take some time to run in remote filesystems, for example NFS. When you have hundreds of them, sos can take a long time to walk through it, and could be even worse if we use the option 'recursive'. For ssh home dirs, we don't need the listing, so in this patch we detect the type of filesystem and run the command only on local ones. Related: RHEL-22389, SUPDEV-156 Signed-off-by: Jose Castillo <[email protected]>
jcastill
force-pushed
the
jcastillo-capture-ssh-userconfs-only-local
branch
from
7eef06b
to
dd8f61d
Compare
Commands like 'ls -laZ' can take some time to run in remote filesystems, for example NFS. When you have hundreds of them, sos can take a long time to walk through it, and could be even worse if we use the option 'recursive'.
For ssh home dirs, we don't need the listing, so in this patch we detect the type of filesystem and run the command only on local ones.
Related: RHEL-22389, SUPDEV-156
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines