[ssh] Add User .ssh Config File Option

[dtzhou2]

Resolves issue SUPDEV-137.
Adds a plugin option for the ssh module, defining whether it will or will not collect .ssh config files per user.
Default for new option is True

Signed-off-by: Daniel Zhou [email protected]

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• [X ] Is the subject and message clear and concise?
• [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
• [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3298
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[arif-ali]

is it worth adding the if statement before the function call for self.user_ssh_files_permissions() instead in the function itself?

if self.get_option('userconfs'):
    self.user_ssh_files_permissions()

The function is not collecting anything else anyhow, but still doing some work; so I think this should be a better way imho

[TurboTurtle]

default should be a boolean here, not a string. We do string conversion to bools from the CLI, but internally we should still be using the correct native type.

[dtzhou2]

fixed issue!

[dtzhou2]

is it worth adding the if statement before the function call for self.user_ssh_files_permissions() instead in the function itself?

if self.get_option('userconfs'):
    self.user_ssh_files_permissions()

The function is not collecting anything else anyhow, but still doing some work; so I think this should be a better way imho

yea I agree with that change

[TurboTurtle]

Ack to the change, but it looks like your commit message got a bit mangled in any fixup work. Let's set that back to what you had with the original [ssh] Add User .ssh Config File Option content (you can do this with git commit --amend)

[TurboTurtle]

Looks like the commit message got murky again in a follow up. To be clear - the commit title should be what is now on the first line ([ssh] Add User .ssh Config File Option). I know this is nitpicky, but this conformance really does help when trawling the git history.

[dtzhou2]

Apologies for that. Don't know why my git commits keep on getting messed up titles. Just fixed