wrap local commands to support different formats #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil | ||
| } | ||
|
|
||
| func Error(out io.Writer, err error, outputFormat config.OutputFormat) error { |
There was a problem hiding this comment.
Looks like this will change the exit status based on the output format, which is odd.
Can we keep the CLI exit status non zero on error? Perhaps using errors.Join when json or yaml or the default switch case, combining the argument error with the error result of the encoding would not change the exit code.
There was a problem hiding this comment.
WDYT on this approach?
|
@davixcky I added a comment here #71 (comment) to the related issue for discussing more what we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.