Add csv to gemspec #609
Open
Add csv to gemspec #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the following warning: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of roo-2.10.1 to add csv into its gemspec.
andyundso
force-pushed
the
csv-to-gemspec
branch
from
a313728
to
b5aa63c
Compare
Nuzair46
approved these changes
Jul 1, 2024
taketo1113
reviewed
Sep 6, 2024
| @@ -23,6 +23,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = ">= 2.7.0" | |||
| end | |||
|
|
|||
| spec.add_dependency 'csv', '~> 3' | |||
There was a problem hiding this comment.
@andyundso It seems it needs to add dependency of base64.
The base64 gem warn same message, warning message details is following:
/path/roo/lib/roo.rb:9: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
Suggested change
| spec.add_dependency 'csv', '~> 3' | |
| spec.add_dependency 'base64' | |
| spec.add_dependency 'csv', '~> 3' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the following warning:
warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of roo-2.10.1 to add csv into its gemspec.
Closes #604