-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Remix 2.12.0 #295
Conversation
} | ||
|
||
return json({ error: null, ok: true }); | ||
return data({ error: null, ok: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the prior one don't need data()
because they don't care about the status
but there's a known issue in our type inference that doesn't like the mixing and matching of data/json/etc. and raw objects so using data everywhere to avoid that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment on the RR PR, should have read this one first.
Thanks for the explanation!
@@ -156,7 +152,7 @@ export default function DocPage() { | |||
); | |||
} | |||
|
|||
function LargeOnThisPage({ doc }: { doc: SerializeFrom<Doc> }) { | |||
function LargeOnThisPage({ doc }: { doc: Doc }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Single Fetch now we just get back a Doc
No description provided.