Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git lfs support #1

Open
wants to merge 1 commit into
base: fix_gemfile
Choose a base branch
from

Conversation

trobol
Copy link

@trobol trobol commented Jun 7, 2021

Adds git lfs support, including locking.

Files are stores within the repo inside lfs/objects

Locks are recorded inside lfs/locks.json

This PR does along with redmine-git-hosting/redmine_git_hosting#791

This patch is missing the ability to discover servers and authenticate over SSH. SSH remotes should still work with lfs but the url and credentials must be set manually.

@alexandermeindl
Copy link

Hi @trobol
it would be great, if you can provide tests for your implementation. LFS is an important feature, but without any tests I would have no good feeling to use it or merge it.

Copy link

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests should cover the new code, before this can be considered for merging

Copy link

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[edited]

Copy link

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[edited]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants