Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] fix flaky reference count test by cleaning up borrowed references if actor is killed before dependencies are not resolved #48091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

When a actor is killed before dependencies are resolved, it doesn't send the reply to the caller (there's a wrong assumption here), and the caller doesn't call proper APIs to clean up borrowed references. This PR fixes the issue by sending a reply when actor is killed before dependencies are resolved and calling FailPendingTask, which in turns clean up borrowed references.

Related issue number

Closes #48087

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 requested a review from a team as a code owner October 17, 2024 20:49
@rkooo567
Copy link
Contributor Author

cpp test fails. I will fix it tmrw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] test_reference_count.py, test_actor_constructor_borrow_cancellation, is really flaky
2 participants