[Core] fix flaky reference count test by cleaning up borrowed references if actor is killed before dependencies are not resolved #48091
+34
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When a actor is killed before dependencies are resolved, it doesn't send the reply to the caller (there's a wrong assumption here), and the caller doesn't call proper APIs to clean up borrowed references. This PR fixes the issue by sending a reply when actor is killed before dependencies are resolved and calling FailPendingTask, which in turns clean up borrowed references.
Related issue number
Closes #48087
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.