[Style]: flake8 violation E721 #48084
Open
+59
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheyu Wu <[email protected]>
CheyuWu
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya,
sven1977,
simonsays1980,
scottjlee,
bveeramani,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: Cheyu Wu <[email protected]>
MortalHappiness
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Generally LGTM, but we should not use isinstance when we need to check two instances are strictly type equal.
cc @rynewang
…e strictly type equal Signed-off-by: Cheyu Wu <[email protected]>
MortalHappiness
approved these changes
Oct 18, 2024
MortalHappiness
requested changes
Oct 18, 2024
Comment on lines
25
to
26
| assert type(a) is type(b), (type(a), type(b)) | ||
| assert type(a[0]) is type(b[0]), (type(a[0]), type(b[0])) |
There was a problem hiding this comment.
I found that for rule E721, the behavior of old and new version of flake8 are different. So maybe add back the # noqa: E721 comment, and then add a TODO comment to say that this # noqa should be removed after flake8 is upgraded. For example: TODO: Remove noqa after flake8 being upgraded to 7.1.1
Failed CI: https://buildkite.com/ray-project/microcheck/builds/6190#0192a009-91f2-402b-b318-d7a5fdc04a24
Old version of flake8:
New version (7.1.1) of flake8:
| @@ -105,7 +105,7 @@ def df_equals(df1, df2): | |||
| if isinstance(df1, pandas.DataFrame) and isinstance(df2, pandas.DataFrame): | |||
| if (df1.empty and not df2.empty) or (df2.empty and not df1.empty): | |||
| assert False, "One of the passed frames is empty, when other isn't" | |||
| elif df1.empty and df2.empty and type(df1) != type(df2): | |||
| elif df1.empty and df2.empty and type(df1) is not type(df2): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
While running the pre-commit hook of flake8, the following error occurs if Python version is 3.12. It's because the version of flake8 is too old.
This commit fixes code that violates the E721 rules.
Related issue number
Closes #48058
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.cc @MortalHappiness