Agnostic local inference #799
Open
+2,688
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
joein
force-pushed
the
agnostic-local-inference
branch
2 times, most recently
from
4f7b120
to
30e4da4
Compare
generall
reviewed
Oct 15, 2024
qdrant_client/qdrant_fastembed.py
Outdated
| model_name = query.model | ||
| if model_name is None: | ||
| raise ValueError( | ||
| "`query_points` requires explicit model name specification for `Document`" |
There was a problem hiding this comment.
We don't know if this method will only be called from query_points
generall
reviewed
Oct 15, 2024
qdrant_client/qdrant_fastembed.py
Outdated
|
|
||
| def _embed_document( | ||
| self, document: models.Document, is_query: bool = False | ||
| ) -> Union[List[float], models.SparseVector]: |
There was a problem hiding this comment.
Late interaction can also return List[List[float]] I propose to define a type alias for this, otherwise too verbose
joein
force-pushed
the
agnostic-local-inference
branch
from
6fb9d64
to
15981e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: