Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter Line Count Report #17809

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Stricter Line Count Report #17809

wants to merge 1 commit into from

Conversation

sagarbadiyani
Copy link

@sagarbadiyani sagarbadiyani commented Sep 22, 2024 •
edited
Loading

Fix #17807

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the LineCoverageVisitor use the same logic? I think your idea of tying it to --disallow-incomplete-defs makes sense too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linecount Report over counting
3 participants
@sagarbadiyani @hauntsaninja @sbadiyani-eightfold